IHCC-cohorts / GECKO

Genomics Cohorts Knowledge Ontology
Other
7 stars 3 forks source link

GECKO rendering tweaks #2

Closed mcourtot closed 2 years ago

mcourtot commented 4 years ago

In the OLS rendering of GECKO, https://registry.ihccglobal.app/ontologies/gecko

mcourtot commented 4 years ago

Current status: ontology IRI should be http://purl.obolibrary.org/obo/gecko.owl

beckyjackson commented 4 years ago

The version of GECKO displayed on OLS is the IHCC view, which is showing up with the correct IRI - http://purl.obolibrary.org/obo/ihcc-gecko.owl

The IRI doesn't resolve correctly, though, because it wasn't added to the PURL configuration. I opened a PR to fix this (OBOFoundry/purl.obolibrary.org#685)

beckyjackson commented 4 years ago

Sorry, the IHCC view PURL should be http://purl.obolibrary.org/obo/gecko/ihcc-gecko.owl - I'll fix this in PR #16

mcourtot commented 3 years ago

The IRI now resolves. Still missing license info and the version IRI returns a 404

jamesaoverton commented 3 years ago

The license is definitely included in the OWL file, and has been for the past six months:

https://github.com/IHCC-cohorts/GECKO/blob/master/gecko.owl#L17

and it shows up correctly on the main OLS:

https://www.ebi.ac.uk/ols/ontologies/gecko

So I suspect a bug with the older version of OLS that we're using.

I made a GitHub release of GECKO as of 2020-12-03 so that the version IRI now resolves:

https://github.com/IHCC-cohorts/GECKO/releases/tag/v2020-12-03

jamesaoverton commented 3 years ago

I was wrong: There's no license for the IHCC version of GECKO, which is why it's not showing up in the IHCC OLS. @beckyjackson can you please fix that?