Update IHCC labels for lifestyle history terms

IHCC-cohorts / GECKO

Genomics Cohorts Knowledge Ontology

Other

7 stars 3 forks source link

Update IHCC labels for lifestyle history terms #27

Closed beckyjackson closed 3 years ago

beckyjackson commented 3 years ago

Resolves #26

drugs -> recreational drug history
alcohol -> alcohol use history
tobacco -> tobacco use history
nutrition -> dietary history
sleep -> sleep history
oral health and hygiene -> oral health history
physical activity -> physical activity history

beckyjackson commented 3 years ago

@mcourtot could you take a quick look and let me know if these changes were what you expected?

Thanks!

mcourtot commented 3 years ago

question around oral health and hygiene becoming oral health history. is it oral (health and hygiene) or is it (oral health) and hygiene (where hygiene could be "how many showers do you take a week" for example) If the former seems good, if the latter we may miss on the hygiene bit with the new mapping?

beckyjackson commented 3 years ago

Good question! I guess I was thinking that things like brushing your teeth and flossing were part of oral health, but I could see that being confusing. Should I change that to "oral health and hygiene history"?

mcourtot commented 3 years ago

Apologies if I was unclear. In the original, does hygiene mean only "oral hygiene" or does it mean hygiene in general? While flossing and brushing teeth are part of oral hygiene, taking a shower would not for example.

beckyjackson commented 3 years ago

No worries. It's only relating to oral hygiene, not other hygiene.

mcourtot commented 3 years ago

thanks! looks great to me.