IHCC-cohorts / GECKO

Genomics Cohorts Knowledge Ontology
Other
7 stars 3 forks source link

Add six cognitive measurements and two diseases #48

Closed beckyjackson closed 3 years ago

beckyjackson commented 3 years ago

Six new cognitive measurement tests in support of the DAC work:

I also changed the other test labels from ending with "measurement" to ending with "score", since a score is really the output from the tests. I can revert this change if we prefer "measurement".

I also added two new disease categories:

MONDO has "disorder of development or morphogenesis", but I don't think this is quite right because this is talking about structural issues whereas we want to cover all congenital/genetic disorders.

I want the browser label for this to be "congenital and genetic disorders" to be more clear that both of those are covered here, so it's more of a grouping term.

Finally, I removed "connective tissue disease" because we already have "musculoskeletal system disease" and thus far we can cover everything with that instead. I can add this back in if we prefer to keep it.

beckyjackson commented 3 years ago

@mcourtot have you had a chance to review these changes? Thanks!

mcourtot commented 3 years ago

I didn't realise you were waiting for me, sorry. They look reasonable to me, tbh you probably know better anyway :)

beckyjackson commented 3 years ago

Thanks much!