search

IHEC / ihec-ecosystems

This repo is for code and documentation associated with the ihec-ecosystems working group
Apache License 2.0
5 stars 6 forks source link

Feb2020 dz #103

Closed dzerbino closed 4 years ago

dzerbino commented 4 years ago

Hello guys,

Please find a proposed merged branch.

Regards,

Daniel

dzerbino commented 4 years ago

Sorry, Thomas could you please do that?

juettemann commented 4 years ago

Done, looks all as expected.

sitag commented 4 years ago

@dzerbino unless there's a rush on getting the merge, I would add tests here. @zxenia can you also add tests for json hub validator part so we can catch any issues on merge?

dzerbino commented 4 years ago

Hello @sitag ,

I'm all in favour of tests, but I'm concerned that the EpiMap project requires us to send error reports to collaborators last January.

Considering that the priority at present is the XML validator and that we do have tests for that, could we not move to merge this branch, and make a point of pushing for tests on the JSON validator in parallel?

Cheers,

Daniel

sitag commented 4 years ago

@dzerbino okay.. merged.