search

IHEC / ihec-ecosystems

This repo is for code and documentation associated with the ihec-ecosystems working group
Apache License 2.0
5 stars 6 forks source link

Adding BIOLOGICAL_REPLICATES to the Specification File #120

Open quirinmanz opened 3 years ago

quirinmanz commented 3 years ago

Hi,

Since BIOLOGICAL_REPLICATES has become a mandatory field in v2 of the validator, it would be very much appreciated if some descriptions were added to the specification file. In the file schemas/json/2.0/sample.json the description says "List of biological replicate sample accessions", but in the example files e.g. version_metadata/examples/sample-Cell_Line-pass_all.xml there is merely a "2" (the number of replicates?).

Thank you in advance.

Best, Quirin

sitag commented 3 years ago

@quirinmanz thanks for bringing this up. indeed this should be sorted out. @juettemann this would need to get fleshed out? perhaps we need to add semantic checks for this attribute