IHEC / ihec-ecosystems

This repo is for code and documentation associated with the ihec-ecosystems working group
Apache License 2.0
5 stars 6 forks source link

Properties conditional on biomaterial_type are not being validated #86

Closed ilsley closed 4 years ago

ilsley commented 4 years ago

The validator converts the BIOMATERIAL_TYPE attribute in the Sample XML file to a JSON array. However, the Sample JSON schema uses conditional validation that assumes the biomaterial_type is a string. This means that the properties specific to each biomaterial_type are not being validated. The following, for example, are not currently being validated nor checked whether they are present: