IHEC / ihec-ecosystems

This repo is for code and documentation associated with the ihec-ecosystems working group
Apache License 2.0
5 stars 6 forks source link

Add assay_type as an additional, more precise, experiment descriptor #9

Closed dbujold closed 8 years ago

dbujold commented 8 years ago

The JSON data hub already includes a proposed "assay_type" identifier, but this should be formalized in the metadata spec, in order to clearly define what goes in there. "assay_type" gives more fine-grained details about the nature of the experiment. For example, if experiment_type is DNA Methylation, then assay_type might be Bisulfite-Seq or 450K or others. What goes in here should be formalized to avoid ("WGB-Seq" vs "Bisulfite-Seq" vs "BS-Seq" vs etc.).

So, the proposal is to have:

assay_type examples: For "http://purl.obolibrary.org/obo/OBI_0001863", asssay_type = "shotgun bisulfite-seq assay" For "http://purl.obolibrary.org/obo/OBI_0002004", assay_type = "Methylation 450K BeadChip"

dbujold commented 8 years ago

From Sita:

I agree with the proposal. However, note that people have been submitting data for a while with the old spec, so tooling around spec will have to be not so strict when dealing with this (especially as the added attributes are computable from attributes in the old spec). In general, I would be against adding such new computable attributes (as it adds no new information), but I think the tag name ASSAY_TYPE vs EXPERIMENT_TYPE is informative.

I propose that we have a class of attributes that should ideally be in the spec, but if absent would be computed in some documented/standardized way from the required attributes.

dbujold commented 8 years ago

Added non-mandatory field "assay_type" to experiment_attributes.