new branch (it contains the upload dto). In the past changes could no…

[bmatern]

…t be pushed (like when editting the upload). Apparently you can push only dto items to the database and not the original item. A couple of extra dtos should be added so that their edits can be pushed correctly to the database.

[bmatern]

Testing this branch, found some interesting points:

1) If I test like this, without changing anything: [Edit Upload] -> [Save] Then the validation status stays as it should, this case is fixed.

2) If I test but Change something like this: [Edit Upload] -> Change File Type from HML to HAML -> [Save] The validation status is lost.

3) If I test but Change something like this: [Edit Upload] -> Change Project 1 to Project 2 -> [Save] The validation status stays as it should, this case is fixed.

In all three cases - the Parent/Child relationship stays intact, so that's pretty cool. Not true when I edit the Child upload however. it becomes separated from it's parent.

This behavior is definitely an improvement, maybe changing the file type should remove the validation. I wonder if renaming the files like this is enough to trigger validations(edit: no, don't think so)

Side note: Edit upload always crashes when the file in the S3 bucket does not exist. Maybe that's ok?

I suggest:

• For case 2: keep the validation when changing file type.
• Maintain the parent when editing the child upload
• Remove the webpack.common changes, I think it is local settings.

[inemp]

Great and detailed testing. I will first try to tackle your "observation 2" and then check the rest

[inemp]

Assumption about the small commit in webpack.common.js is indeed not necessary, tested it and it didn't exhibit different behavior

[inemp]

fixed also the issue with changing file type. pushed changes