search

IHP-GmbH / IHP-Open-PDK

130nm BiCMOS Open Source PDK, dedicated for Analog, Mixed Signal and RF Design
Apache License 2.0
306 stars 41 forks source link

DRC violation in sealring #116

Closed dnltz closed 2 weeks ago

dnltz commented 2 weeks ago

Layout rules define GFil.d with a gap of 1.1u between GatPoly:filler and pSD. The current sealring only has 1.0u and therefore fails this check.

image

dnltz commented 2 weeks ago

Only the horizontal filler cells are affected. Verticals have a gap of 1.1u.

dnltz commented 2 weeks ago

https://github.com/IHP-GmbH/IHP-Open-PDK/blob/f5c16b18d8d7048e65e7bd63d392d065fec73d4b/ihp-sg13g2/libs.tech/klayout/python/sg13g2_pycell_lib/ihp/sealring_code.py#L191

The second last parameter should be changed from 1.0 to 1.1

sergeiandreyev commented 2 weeks ago

Unfortunately, after review we see that we have a disconnect between the sealring in the OpenPDK and the internal one (left - internal implementation, right - OpenPDK): image we're going to remove the internal filler generation code altogether from the sealring Pycell, this way the external script should be used and also we will get rid of these errors that you're mentioning here

dnltz commented 2 weeks ago

Should be solved with https://github.com/IHP-GmbH/IHP-Open-PDK/pull/117

@sergeiandreyev can we close it?

sergeiandreyev commented 2 weeks ago

yes, sure, thank you again! in the meantime I'll cross check the updated Pycell with the internal implementation