search

IHP-GmbH / IHP-Open-PDK

130nm BiCMOS Open Source PDK, dedicated for Analog, Mixed Signal and RF Design
Apache License 2.0
295 stars 39 forks source link

A few more questions about nmos_code.py #89

Open eskiyerli opened 2 weeks ago

eskiyerli commented 2 weeks ago

  1. I don't understand why you would define epsilon twice:

    self.epsilon = techparams['epsilon1']
Cell = self.__class__.__name__
typ = 'N'
hv = False

epsilon = techparams['epsilon1']
  2. epsilon is defined as "epsilon1": 0.001, in json file. What is the purpose of this code: ng = math.floor(Numeric(ng)+epsilon) As far as I see, it has no effect.
eskiyerli commented 2 weeks ago

Why is it invalid?

KrzysztofHerman commented 2 weeks ago

It is only a marker for our team to check validity.

sergeiandreyev commented 22 hours ago

@eskiyerli, I agree, there is long way to go to fine-tune and even clean-up the code..