search

IHTSDO / authoring-acceptance-gateway

Microservice to ensure service acceptance criteria are met before content promotion within the SNOMED CT Authoring Platform.
Other
0 stars 1 forks source link

FRI-54 Change CommitInformation to have source & target branch paths #12

Closed dmcgihtsdo closed 3 years ago

dmcgihtsdo commented 3 years ago

FRI-54 is concerned with either allowing or disallowing a project promotion depending on whether the appropriate criteria have been completed. The previous PR related to FRI-54 submitted was not fully tested and had a slight oversight.

Currently, when Snowstorm is promoting, the target branch will be sent to AAG for criteria verification rather than the source branch.

dmcgihtsdo commented 3 years ago

The bulk of the changes within this PR are simply changing branchPath to sourceBranchPath. Within this code base, targetBranchPath is never used, but I think having both sourceBranchPath and targetBranchPath, along with the existing CommitType will help reduce any mental gymnastics involved and help contextualise CommitInformation.

dmcgihtsdo commented 3 years ago

I had to rebase and resolve conflicts before merging. I shall merge now.