search

IHTSDO / snomed-expression-constraint-language

Formal syntax and valid examples for each version of ECL
http://snomed.org/ecl
Other
3 stars 3 forks source link

Rename "match" rule to avoid conflict with ANTLR API #3

Closed johngrimes closed 2 years ago

johngrimes commented 2 years ago

Unfortunately, naming a rule "match" breaks the JavaScript implementation of ANTLR. The Java API seems to be tolerant of this, which is why it works within the Java example project.

I am aware that this file is generated (generated + some manual changes?). I'm not sure if this change is fine in isolation, or if a corresponding change to the ABNF should also be made.

kaicode commented 2 years ago

Hi @johngrimes, good point about the JavaScript reserved word/language clash. I have asked Linda Bird to add this to the agenda for the languages group call on Thursday. Yes, I think a corresponding ABNF change is needed but it's fine, I can sort that.

There are some minor manual changes in the ANTLR file related to the UFT-8 character set. Any other minor changes should be non-functional changes. As far as I am aware all changes that can be represented in the ABNF have been made there.

We are planning an ECL version 2.1 to introduce description identifier filtering, requested by the UK. It seems likely that this change you requested will be folded into that version.

johngrimes commented 2 years ago

Great, thanks so much @kaicode!

kaicode commented 2 years ago

This is now part of ECL 2.1 which was published a couple of weeks ago now. I will update this repo with the new language version.

kaicode commented 2 years ago

@johngrimes when you have a minute could you rebase this branch and send me an email, then I will merge it in. Thank you. It's my bad because I had to do a force push just now which may have made your branch out of sync.

johngrimes commented 2 years ago

@kaicode I've updated the branch