search

IHTSDO / snomed-scg-parser

An Open Source Java library for parsing SNOMED Post-Coordinated expressions written in SNOMED Compositional Grammar.
Other
7 stars 5 forks source link

DLM-387 allow arbitrary subexpression bracketing #7

Closed lawley closed 4 years ago

kaicode commented 4 years ago

Hi @lawley, the file you have suggested changes to was actually generated from the ABNF provided by Linda. Your change looks sensible but I don't want it to lost when the file is regenerated. Do you happen to know if our ABNF file is out of date or if there has been any discussion in this area?

lawley commented 4 years ago

On reflection, this change is insufficient -- attributename needs to be updated, and expressionvalue should be focusconcept, not conceptreference.

lawley commented 4 years ago

Thanks Kai, I've opened a ticket on the spec which is where I presume the ABNF source if truth is.

Michael

Michael

From: Kai Kewley notifications@github.com Sent: Friday, June 26, 2020 8:01:33 PM To: IHTSDO/snomed-scg-parser snomed-scg-parser@noreply.github.com Cc: Michael Lawley michael@lawley.id.au; Mention mention@noreply.github.com Subject: Re: [IHTSDO/snomed-scg-parser] DLM-387 allow arbitrary subexpression bracketing (#7)

@kaicode requested changes on this pull request.

Looks like our ABNF file is up to date with the latesthttps://confluence.ihtsdotools.org/display/DOCSCG/5.1+Normative+Specification apart from the booleanValue addition. Could you ask Linda to make your suggested change in the upstream specification then I would be happy to pull that in and regenerate the Antlr file and parser.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/IHTSDO/snomed-scg-parser/pull/7#pullrequestreview-438170830, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGDWXQMWPXLWLROFFRIYKTRYRWX3ANCNFSM4OJFICDA.