search

IHTSDO / snow-owl

Snow Owl Terminology Server. This version is no longer maintained. Please use the upstream version or the alternate Snowstorm Terminology Server.
Apache License 2.0
11 stars 1 forks source link

Reduce amount of doc lookups during change processing #6

Closed cmark closed 8 years ago

cmark commented 8 years ago

This PR reduces the execution time of a commit by 10%.

kaicode commented 8 years ago

Thanks Márk. Please could you indicate the level of testing that has been carried out on this code and suggest specific areas that should be tested manually by us after taking this change.

cmark commented 8 years ago

We usually do two things when developing and submitting PRs:

  1. run the integration tests
  2. do a quick manual testing using the API (like create/update/delete concepts/descriptions/relationships/members and other affected endpoints)

If those were okay, then we'll create a pull request for code review and assign someone to review it. After that we merge the PR, our QA team can take over and verify the changes (they did not receive this enhancement yet, it will be tested with the release of 4.7.0). See the same PR in our repository: https://github.com/b2ihealthcare/snow-owl/pull/73

On your end, I'd test any operation that makes changes in the ontology, because the PR modifies the commit process. Essentially this would be create new concept/description/relationship/member, classification+save results, update (eg. inactivation) and deletion.

kaicode commented 8 years ago

Perfect, thanks. I will pull this next sprint.