Open FilipTNH opened 2 years ago
Partially solved: The wrong endpoint was used to rebase SNOMEDCT-BE PUT /codesystems/{shortName} (Update a code system) in stead of the correct one: POST /codesystems/{shortName}/upgrade (Upgrade code system to a different dependant version.)
See also https://github.com/IHTSDO/snowstorm/issues/325
=> Upload of BE-2021-09-15 now completed succesfully.
The use of this wrong endpoint seems to cause a problem for the Snomed CT browser to correctly load and present the available extensions. (testing in the background to query specific info with curl from browser to Snowstorm is working, so that is not a problem).
Attempting to change the code system dependant version via PUT /codesystems/{shortName}
will not do anything at all because the dependant version is not part of the request format of that endpoint.
I am not certain if importing BE 2021-09-15 first and then upgrading would work..
What response are you getting from GET /codesystems/SNOMEDCT-BE
?
It's worth checking what the values are in dependantVersionEffectiveTime
, latestVersion > effectiveDate
and latestVersion > dependantVersionEffectiveTime
.
Hello Kai, Thanks for your mail. This is the info from SNOMEDCT-BE
{ "shortName": "SNOMEDCT-BE", "branchPath": "MAIN/SNOMEDCT-BE", "dependantVersionEffectiveTime": 20210731, "dailyBuildAvailable": false, "latestVersion": { "shortName": "SNOMEDCT-BE", "importDate": "2021-11-23T15:45:47.583Z", "parentBranchPath": "MAIN/SNOMEDCT-BE", "effectiveDate": 20210915, "version": "2021-09-15", "description": "SNOMEDCT-BE 20210915 import.", "dependantVersionEffectiveTime": 20210731, "branchPath": "MAIN/SNOMEDCT-BE/2021-09-15" }, "languages": { "fr": "Frans", "nl": "Nederlands", "en": "Engels" }, "modules": [ { "conceptId": "900000000000012004", "active": true, "definitionStatus": "PRIMITIVE", "moduleId": "900000000000012004", "effectiveTime": "20020131", "fsn": { "term": "SNOMED CT model component module (core metadata concept)", "lang": "en" }, "pt": { "term": "SNOMED CT model component", "lang": "en" }, "id": "900000000000012004", "idAndFsnTerm": "900000000000012004 | SNOMED CT model component module (core metadata concept) |" }, { "conceptId": "11000172109", "active": true, "definitionStatus": "PRIMITIVE", "moduleId": "11000172109", "effectiveTime": "20180315", "fsn": { "term": "Belgian module (core metadata concept)", "lang": "en" }, "pt": { "term": "Module Belge", "lang": "fr" }, "id": "11000172109", "idAndFsnTerm": "11000172109 | Belgian module (core metadata concept) |" }, { "conceptId": "449080006", "active": true, "definitionStatus": "PRIMITIVE", "moduleId": "900000000000012004", "effectiveTime": "20110731", "fsn": { "term": "SNOMED CT to ICD-10 rule-based mapping module (core metadata concept)", "lang": "en" }, "pt": { "term": "SNOMED CT to ICD-10 rule-based mapping module", "lang": "en" }, "id": "449080006", "idAndFsnTerm": "449080006 | SNOMED CT to ICD-10 rule-based mapping module (core metadata concept) |" }, { "conceptId": "900000000000207008", "active": true, "definitionStatus": "PRIMITIVE", "moduleId": "900000000000012004", "effectiveTime": "20020131", "fsn": { "term": "SNOMED CT core module (core metadata concept)", "lang": "en" }, "pt": { "term": "SNOMED CT core", "lang": "en" }, "id": "900000000000207008", "idAndFsnTerm": "900000000000207008 | SNOMED CT core module (core metadata concept) |" } ], "userRoles": [] }
Filip
Van: Kai Kewley @.> Verzonden: dinsdag 23 november 2021 18:25 Aan: IHTSDO/snowstorm @.> CC: Filip Veldeman @.>; Author @.> Onderwerp: Re: [IHTSDO/snowstorm] Upgrade of BE extension fails on Snowstorm-7.4.0 (Issue #341)
Attempting to change the code system dependant version via PUT /codesystems/{shortName} will not do anything at all because the dependant version is not part of the request format of that endpoint.
[Screenshot 2021-11-23 at 17 17 48]https://user-images.githubusercontent.com/2010517/143072771-c6ac69ed-ade9-4db4-acf6-3108a7611c9b.png
I am not certain if importing BE 2021-09-15 first and then upgrading would work.. What response are you getting from GET /codesystems/SNOMEDCT-BE ? It's worth checking what the values are in dependantVersionEffectiveTime, latestVersion > effectiveDate and latestVersion > dependantVersionEffectiveTime.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/IHTSDO/snowstorm/issues/341#issuecomment-976886184, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARDBZ3X2IDD7KA6BPRCYPL3UNPFCJANCNFSM5ITWYAZQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
That looks okay to me. Are you still having browser issues?
Just read the browser issue 66.
It sounds like you may need to delete your Snowstorm Elasticsearch indices and start again.
You can do this by starting Snowstorm with the flag --delete-indices
when starting Snowstorm, see command line example.
Loading INT-2021-01-31 oké Loading BE-2021-03-15 oké Loading INT-2021-07-31 oké Rebase of SNOMEDCT-BE to point to INT-2021-07-21 oké ? { "contentAutomations": false, "newDependantVersion": 20210731 } Status of the branch MAIN/SNOMEDCT-BE = Diverged Loading BE-2021-09-15 => fails and rolls back java.lang.IllegalStateException: No MRCM range constraint is defined for concrete attribute 1142139005 Full Snowstorm log is attached. Snowstormlog.txt
Thanks for further advise, Kind regards, Filip Veldeman