Rename variable / method

IHTSDO / snowstorm

Scalable SNOMED CT Terminology Server using Elasticsearch

Other

204 stars 80 forks source link

Rename variable / method #40

Closed pgwilliams closed 5 years ago

pgwilliams commented 5 years ago

Is the "termPrefix" really a prefix? I'm calling it to find matching text anywhere in the term. Would a clearer name be "termMatch" or "termFilter" ? Thanks!

https://github.com/IHTSDO/snowstorm/blob/9ec26802f91fe3e6f0c7a27b2d35f8493ccd4b7c/src/main/java/org/snomed/snowstorm/core/data/services/QueryService.java#L501

PS Just used it to implement a FHIR parameter in under 5 mins - bonus!

kaicode commented 5 years ago

You are right. I like termMatch 👍

pgwilliams commented 5 years ago

Addressed in STORM-206