IHTSDO / snowstorm

Scalable SNOMED CT Terminology Server using Elasticsearch
Other
204 stars 80 forks source link

Refset expansion in ECL incomplete #48

Closed danka74 closed 5 years ago

danka74 commented 5 years ago

Running snowstorm develop@8d0d54c with Swedish edition loaded: I tried expanding refsets using the refset API vs. ECL: http://localhost:8080/MAIN%2FSNOMEDCT-SE/members?referenceSet=58191000052103&active=true&offset=0&limit=50 and got 76 members (which is correct), but http://localhost:8080/MAIN%2FSNOMEDCT-SE/concepts?activeFilter=true&ecl=%5E58191000052103&offset=0&limit=50​ gives me 41 members...

kaicode commented 5 years ago

The member-of ECL selection will only return concepts where both the reference set member and concept are active. Perhaps your reference set member search is returning more results because there active members referencing inactive concepts?

kaicode commented 5 years ago

We have the Swedish Edition loaded here using the develop branch of Snowstorm and are getting 76 results back for both member and ECL requests.

danka74 commented 5 years ago

I'm have the MAY19 pre-release loaded. Maybe that's the issue... I'll try to load the previous release. /Daniel

rorydavidson commented 5 years ago

Yep, we're using International July 2018 and Swedish November 2018 are the results match across all reference sets for both different calls.

danka74 commented 5 years ago

I tested Int July 2018 + SE Nov 2018 (both snapshot) and I got 3 members using ECL instead of 76 using the refset operations. Something is seriously fishy, seems like on my end.

rorydavidson commented 5 years ago

@danka74 what is the branch and import strategy that you've used? The one I've followed is (from a clean server):

Still getting the results as expected.

danka74 commented 5 years ago

@rorydavidson I updated to elasticsearch 6.5.4, reloaded everything, and now I have 76 members using both operations!