IHTSDO / snowstorm

Scalable SNOMED CT Terminology Server using Elasticsearch
Other
204 stars 80 forks source link

Releases MD5 file not properly formatted for `md5sum` to work: Missing `.jar` file name #556

Open o-l-a-v opened 1 year ago

o-l-a-v commented 1 year ago

Take latest release, 8.3.0:

The MD5 file looks like this:

0939babdb90f2c6aea5f1750b27a8d74

But should look like this:

0939babdb90f2c6aea5f1750b27a8d74 snowstorm-8.3.0.jar

For md5sum --check snowstorm-8.3.0_jar.md5 to work.

kaicode commented 1 year ago

It looks like we are not using the MD5 file in the standard way. Wikipedia seems to confirm this checksum-filename pair format: https://en.wikipedia.org/wiki/Md5sum#Create_MD5_hash_file_hash.md5

@CoderMChu any thoughts on this? Could we change our MD5 file format to match?

o-l-a-v commented 1 year ago

It's probably a good idea to consider moving away from MD5 while we're at it. Consider SHA-2 or SHA-3 to follow NIST recommendations: