search

IHTSDO / snowstorm

Scalable SNOMED CT Terminology Server using Elasticsearch
Other
204 stars 80 forks source link

FHIR API $lookup - query response with normalForm property #571

Open JonZammit opened 10 months ago

JonZammit commented 10 months ago

When including the normalForm property in the $lookup operation, the response includes the expression, however the expression does not include the symbols for equivalent === or subtype <<<.

For example the SNOMED CT browser indicates the expression for 233604007 |Pneumonia| as "=== 95436008 |Lung consolidation (disorder)| + 205237003 |Pneumonitis (disorder)| : { 363698007 |Finding site (attribute)| = 39607008 |Lung structure (body structure)|, 116676008 |Associated morphology (attribute)| = 707496003 |Inflammation and consolidation (morphologic abnormality)| }".

But observe the query response for: https://snowstorm.snomedtools.org/fhir/CodeSystem/$lookup?system=http://snomed.info/sct&code=233604007&property=normalForm

normalForm valueString is indicated as "95436008|Lung consolidation (disorder)| + 205237003|Pneumonitis (disorder)| : { 363698007|Finding site (attribute)| = 39607008|Lung structure (body structure)|, 116676008|Associated morphology (attribute)| = 707496003|Inflammation and consolidation (morphologic abnormality)| }"

pgwilliams commented 10 months ago

Raised internal ticket INFRA-12101 for this, which I expect to move to the MAINT project.

kaicode commented 10 months ago

There are a couple of small things in this area. The normalFormTerse has the same issue with missing definition status. The normalFormTerse should also have any whitespace removed. https://snowstorm.snomedtools.org/fhir/CodeSystem/$lookup?system=http://snomed.info/sct&code=233604007&property=normalFormTerse