search

IHateMyKite / UnforgivingDevices

UD is framework extension for mod Devious Devices which focuses on adding more immersive and complex escape system.
https://www.loverslab.com/files/file/16938-unforgiving-devices/
GNU General Public License v3.0
4 stars 6 forks source link

Version 3.0 Implementation #183

Closed IHateMyKite closed 6 months ago

IHateMyKite commented 7 months ago

Renamed branches, so previous PR got basically removed. It can be seen here https://github.com/IHateMyKite/UnforgivingDevices/pull/178

IHateMyKite commented 7 months ago

The UD_Config file seems to be missing from this pull request when i compare it to the previous one.

The number of edited lines is also different when you compare the two pull requests.

That is because there were some additional PR in between, which were then merged in. While this tries to merge directly to main branch. Either way, if you look at UD_Config in the last commit, you will see it is same as the one from previous PR

IHateMyKite commented 6 months ago

Meanwhile found another minor thing: when helper helps to unlock restraints, after unlocking first lock, minigame still continues without selecting the next lock to unlock. If this was the last lock - it works as it should.

Cant reproduce. Does this happens all the time, or only sometimes ?

kurotatsu77 commented 6 months ago

Meanwhile found another minor thing: when helper helps to unlock restraints, after unlocking first lock, minigame still continues without selecting the next lock to unlock. If this was the last lock - it works as it should.

Cant reproduce. Does this happens all the time, or only sometimes ?

Rechecked with the latest dll and all recompiled scripts. a. When player helps follower to unlock - everything works as it should, locks are opened one after another, when one lock opened - dialogue appears to select the next as it should. b. When follower help player to unlock their restraint, after unlocking first lock minigame continues, no dialogue to select the next lock appears, hitting crits does nothing. So to unlock lock you have to start another unlock game once per lock remaining, and when the last lock is opened - restraint removed and minigame ends properly.

This effect appears each time without fail when player receives unlocking help from follower (helper). When player unlocks themselves or NPC - everything always works perfectly.

kurotatsu77 commented 6 months ago

Please see https://github.com/IHateMyKite/UnforgivingDevices/issues/184

IHateMyKite commented 6 months ago

Please see #184

Will fix with new PR. Closing this now, so I can separate different issues/features in different PRs