search

IHateMyKite / UnforgivingDevices

UD is framework extension for mod Devious Devices which focuses on adding more immersive and complex escape system.
https://www.loverslab.com/files/file/16938-unforgiving-devices/
GNU General Public License v3.0
4 stars 6 forks source link

Fixes and improvements #201

Closed IHateMyKite closed 3 weeks ago

IHateMyKite commented 1 month ago

Requires new DD API from commit https://github.com/ponzipyramid/DeviousDevicesNG/commit/1d622bcf57acbb7d081ecaa65ccbe28a72634294

IHateMyKite commented 1 month ago

@kurotatsu77 Let me know if the last commit fixes the #202 . It requires the latest dll from DDNG repo. Here it is for simplicity DeviousDevices.zip

kurotatsu77 commented 1 month ago

@kurotatsu77 Let me know if the last commit fixes the #202 . It requires the latest dll from DDNG repo. Here it is for simplicity DeviousDevices.zip

Ran this PRNB and DLL you supplied - yep, both issues are fixed now. All inflation events fire off properly. Also tested SwapDevices function - worked as expected this time.

While testing spotted weird bug - after player control disabled and enabled again sometimes part of control still stays disabled, like mingame is running. This disabled state persists even through game being loaded and even through exit to main menu and load game! Running UD fixes not re-enables controls. But running any UD minigame restores controls properly. Issue can be spotted by running DIN free use feature or some other scenes which disable player controls. It's not 100%, seems a bit random. And I'm quite sure I never saw it before I've used dll from here. Something to investigate?

IHateMyKite commented 1 month ago

@kurotatsu77 Let me know if the last commit fixes the #202 . It requires the latest dll from DDNG repo. Here it is for simplicity DeviousDevices.zip

Ran this PRNB and DLL you supplied - yep, both issues are fixed now. All inflation events fire off properly. Also tested SwapDevices function - worked as expected this time.

While testing spotted weird bug - after player control disabled and enabled again sometimes part of control still stays disabled, like mingame is running. This disabled state persists even through game being loaded and even through exit to main menu and load game! Running UD fixes not re-enables controls. But running any UD minigame restores controls properly. Issue can be spotted by running DIN free use feature or some other scenes which disable player controls. It's not 100%, seems a bit random. And I'm quite sure I never saw it before I've used dll from here. Something to investigate?

Can you share the UD_Native.log with maximum logging when this issue happens ? Also, can this be replicated ?

kurotatsu77 commented 4 weeks ago

Can you share the UD_Native.log with maximum logging when this issue happens ? Also, can this be replicated ?

Tried hard to replicate this issue and didn't managed to do so... Probably can be written off as weird script lag I guess...

IHateMyKite commented 3 weeks ago

Can you share the UD_Native.log with maximum logging when this issue happens ? Also, can this be replicated ?

Tried hard to replicate this issue and didn't managed to do so... Probably can be written off as weird script lag I guess...

In that case, I think this is ready to be merged. This PR should fix all 3 latest problems. Can you do a quick review ?