search

IIIF-Commons / iiif-metadata-component

MIT License
2 stars 11 forks source link

CopyText-element always has english title #8

Closed Edminsson closed 1 week ago

Edminsson commented 6 years ago

MetadataComponent uses data.content.copyToClipboard to set the title attribute of $copyTextTemplate. The property _data of MetadataComponent is initialized in the data method. In the base class of Metadatacomponent options.data is initialized to the merged value of the data method and options.data. Wouldn't it be better to use options.data.content.copyToClipboard?

demiankatz commented 1 week ago

As of today, the code already seems to be using options.data.content.copyToClipboard, so I believe this issue was fixed some time ago (before 2019) yet the issue was never closed. Closing now.