search

IIIF-Commons / presentation-3-normalized

MIT License
1 stars 0 forks source link

Provider has the wrong type (Normalized) #2

Open stephenwf opened 2 years ago

stephenwf commented 2 years ago

The reference here was not updated after changing to Provider in IIIF-Commons/presentation-3-types#2 https://github.com/IIIF-Commons/presentation-3-types/blob/main/iiif/descriptive.d.ts#L191 cc @jbaiter

stephenwf commented 2 years ago

Related to: https://github.com/IIIF-Commons/parser/pull/4 Which looks like Agent is correct, and Provider might be wrong.

Could be a Vault bug in inferring what Referece<'Agent'> resolves to.

edit: I think this is just confusing naming https://github.com/IIIF-Commons/vault/blob/0bc160857d768036a66099d272d947d63a4d2a7d/src/types.ts#L77-L80

With Agent / ResourceProvider being used interchangeably.