search

IIIF-Commons / thumbnail-panel

https://thumbnail-panel.netlify.app
MIT License
3 stars 1 forks source link

Update build config to support React component lib importing by consumers #22

Closed adamjarling closed 1 year ago

adamjarling commented 1 year ago

Supports components being imported into an external React app. 

import { ThumbnailPanel } from "@iiif/thumbnail-panel";
codesandbox[bot] commented 1 year ago

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

netlify[bot] commented 1 year ago

Deploy Preview for thumbnail-panel ready!

Name Link
Latest commit 68fd9158c376f07ac7950b4aee8b96f70827adfb
Latest deploy log https://app.netlify.com/sites/thumbnail-panel/deploys/644815e1f3594a000817358f
Deploy Preview https://deploy-preview-22--thumbnail-panel.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

mathewjordan commented 1 year ago

~@adamjarling From a consuming app, I'm trying to do a test of this by install the package from the github branch and its not really working as expected. Maybe I'm not doing something correctly. Mind sitting with me for a second to see if you can do it on your end?~

npm i git@github.com:IIIF-Commons/thumbnail-panel.git#20-update-build-for-lib

Scratch the above! It worked after I adjusted for a silly mistake on my part. Note the Items below a simple OSD viewer.

image

stephenwf commented 1 year ago

@mathewjordan does it also work with the CodeSandbox preview?

npm i https://pkg.csb.dev/IIIF-Commons/thumbnail-panel/commit/68fd9158/@iiif/thumbnail-panel