search

IIIF-Commons / thumbnail-panel

https://thumbnail-panel.netlify.app
MIT License
3 stars 1 forks source link

Fix changing behavior override #42

Closed adamjarling closed 1 year ago

adamjarling commented 1 year ago

What does this do?

The layout of thumbnails is determined in part, by Manifest overrides. Somewhere along the line this got knocked loose. This PR fixes changes in behavior under overrides.

codesandbox[bot] commented 1 year ago

This branch is running in CodeSandbox. Use the links below to review this PR faster.
CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

netlify[bot] commented 1 year ago

Deploy Preview for thumbnail-panel ready!

Name Link
Latest commit 8b6ad531f7696d2465517f71f58f25a0c7582421
Latest deploy log https://app.netlify.com/sites/thumbnail-panel/deploys/6477938cc1c8170008f2be7a
Deploy Preview https://deploy-preview-42--thumbnail-panel.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

adamjarling commented 1 year ago

@mathewjordan Yea, noticed that too. I think it's cause it was originally set up with a default value of undefined, which just needs to get handled better. Maybe in the interest of time, I'll create a separate issue for it?