IIIF / cookbook-recipes

For working on the recipes
https://iiif.io/api/cookbook/index.html
37 stars 32 forks source link

0068 Newspaper's FragmentSelector(s) contain the hash delimiter #468

Closed ksclarke closed 7 months ago

ksclarke commented 8 months ago

Recipe info:

Correction request

I'm not an expert on this so could be wrong, but am wondering if the FragmentSelector(s) in the newspaper recipes should contain the hash (like they currently do). For an example see https://github.com/IIIF/cookbook-recipes/blob/5cf4ddf2946528c8bde0507a2e8e75a8724b8c8b/recipe/0068-newspaper/newspaper_issue_1-anno_p1.json#L29

If I look in the W3C Annotation Data Model documentation (https://www.w3.org/TR/annotation-model/#fragment-selector), the values don't contain the hash delimiters, but just the value itself (e.g. xywh=50,50,640,480).

I think that the hash should not be included at the start of the FragmentSelector value in the cookbook recipe, that it is something that should be added on URL construction. Is this incorrect?

glenrobson commented 8 months ago

Cookbook authors agree. Glen will create a correction.

ksclarke commented 8 months ago

@glenrobson Since the authors agreed, I went ahead and created a PR for this.