search

IIIF / image-validator

Validator for the Image API
http://iiif.io/api/image/validator/
Apache License 2.0
35 stars 20 forks source link

Validator does not check the @id field for correct structure. #16

Closed aeschylus closed 9 years ago

aeschylus commented 10 years ago

Run a check that makes sure the contents of the @id field on the info.json does, in fact, contain all segments of the API call. See this result.

The @id test just tests that the @id field exists and is a uri, not that it is properly structured IIIF. Compare the above result with the info.json corresponding to the above test result.

azaroth42 commented 10 years ago

The @id field MUST NOT contain all segments of the API.

So this is not a bug.

On Thu, Oct 23, 2014 at 12:29 PM, aeschylus notifications@github.com wrote:

Run a check that makes sure the contents of the @id https://github.com/id field on the info.json does, in fact, contain all segments of the API call. See this result http://iiif.io/api/image/validator/results.html?server=http%3A%2F%2Fdams.llgc.org.uk%2F&prefix=iiif%2Fimage&identifier=4574753&version=1.1&level=1&id_squares=on&id_basic=on&info_json=on&id_error_unescaped=on&id_error_random=on&id_error_escapedslash=on&id_escaped=on&region_error_random=on&region_pixels=on&size_region=on&size_wc=on&size_error_random=on&size_ch=on&size_percent=on&rot_region_basic=on&rot_error_random=on&rot_full_basic=on&quality_error_random=on&format_jpg=on&format_error_random=on&format_conneg=on&CORS=on.

The @id https://github.com/id test just tests that the @id https://github.com/id field exists and is a uri, not that it is properly structured IIIF. Compare the above result with the info.json http://dams.llgc.org.uk/iiif/image/4574753/info.json corresponding to the above test result.

— Reply to this email directly or view it on GitHub https://github.com/IIIF/image-api/issues/16.

Rob Sanderson Technology Collaboration Facilitator Digital Library Systems and Services Stanford, CA 94305

aeschylus commented 10 years ago

Sorry, I don't think I put it correctly. The Wales info.json @id field lacks the identifier segment, making it impossible to dereference. The first table in http://iiif.io/api/image/2.0/#image-information says that it should (unless I'm misreading it).

Have a look at the example I posted to see if it is correct. As far as I could tell the validator did not confirm the correct structure (assuming it should in fact contain the identifier for dereferencing purposes).

azaroth42 commented 10 years ago

Ahh, that should be testable, yes.

On Thu, Oct 23, 2014 at 1:20 PM, aeschylus notifications@github.com wrote:

Sorry, I don't think I put it correctly. The Wales info.json @id https://github.com/id field lacks the identifier segment, making it impossible to dereference. The first table in http://iiif.io/api/image/2.0/#image-information says that it should (unless I'm misreading it).

— Reply to this email directly or view it on GitHub https://github.com/IIIF/image-api/issues/16#issuecomment-60230431.

Rob Sanderson Technology Collaboration Facilitator Digital Library Systems and Services Stanford, CA 94305

azaroth42 commented 9 years ago

Fixed locally, will close when it's online.