IIIF / image-validator

Validator for the Image API
http://iiif.io/api/image/validator/
Apache License 2.0
35 stars 20 forks source link

Validator should include a tests using a non-square image to test for x,y transposition errors etc. #25

Open zimeon opened 9 years ago

zimeon commented 9 years ago

Suggested by Jeremy Echols on iiif-discuss

Yes, I did use the validator. I found it to be EXTREMELY helpful, actually, as I was previously just kind of testing and hoping :)

There was only one issue I noticed - the test image is square, so it didn't catch a bug I had made in resizing where I had accidentally swapped width and height. It might be helpful to have a test image that isn't a perfect square, but I don't know how often such a stupid bug is likely to hit others, so it may be more time to do that than it's worth

I notes that having a non-square image also will allow checking that the direction of rotation is correct and that the axis for mirroring is correct.

azaroth42 commented 9 years ago

:+1: I think there should be one non-square image. For 2.1 we can generate a new image, also for the square region, which is otherwise the entire image.

zimeon commented 9 years ago

I guess there is no reason at all to have a square image so I agree that making the one test image non-square solves the problem