IIIF / presentation-validator

Validator for the Presentation API
http://iiif.io/api/presentation/validator/
43 stars 36 forks source link

Validator considers Public Domain Mark invalid #169

Closed DavidHaskiya closed 9 months ago

DavidHaskiya commented 9 months ago

Hi, When we tested our manifests we got an error from the validator for using https://creativecommons.org/publicdomain/mark/1.0/ as our rights value.

Is that as intended?

presentationvalidator_invalidPDM

glenrobson commented 9 months ago

It should be OK with the reg ex expression here: https://github.com/IIIF/presentation-validator/blob/c3283776ef60161e40677ac96632fa507602c0aa/schema/iiif_3_0.json#L259

{
                    "type": "string",
                    "format": "uri",
                    "pattern": "http://creativecommons.org/publicdomain/.*"
},

Do you have the manifest aviliable so I can test?

DavidHaskiya commented 9 months ago

Sure! Here's a manifest that throws the error, https://lbiiif.riksarkivet.se/arkis!R0003158/manifest

mikeapp commented 9 months ago

Use http see https://github.com/IIIF/api/issues/1874

glenrobson commented 9 months ago

Ah yes sorry I didn't notice it was https and as Mike mentions that will be why its failing validation.

DavidHaskiya commented 9 months ago

Thank you! We will fix that in our next sprint!