Make it clear that `type` is required on `thumbnail` and `logo` - Githubissues

IIIF / trc

Technical Review Committee issue review

Apache License 2.0

1 stars 1 forks source link

Make it clear that `type` is required on `thumbnail` and `logo` #27

Open zimeon opened 5 years ago

zimeon commented 5 years ago

Links

Original Issue: https://github.com/IIIF/api/issues/1835
Pull Request: https://github.com/IIIF/api/pull/1843
Preview: https://preview.iiif.io/api/issue-1835/api/presentation/3.0/#thumbnail & https://preview.iiif.io/api/issue-1835/api/presentation/3.0/#logo

Background and Summary

The specification draft had become inconsistent. We decided that the type is required for thumbnail (IIIF/api#1147) and indeed for all objects (IIIF/api#1185), but the descriptions of thumbnail and logo still say it is optional. There should be clarity that type is required.

Proposed Solution

We considered (on IIIF/api#1835) whether to simply omit mention of type because it is covered elsewhere, or whether to repeat that it is required. The proposal is to explictly state that type MUST be present.

azaroth42 commented 5 years ago

Issue 27 (Make it clear that `type` is required on `thumbnail` and `logo`)

+1: 32 [ahankinson aisaac andrewgunther azaroth42 beaudet cubap dismorfo emulatingkat gigamorph glenrobson hadro irv jbhoward-dublin jonhartzler joshuago78 jpstroop jtweed julsraemy markpatton mattmcgrattan mcwhitaker mejackreed mikeapp mixterj regisrob rentonsa rsinghal scossu sredick tomcrane tpendragon zimeon] 0: 0 [] -1: 0 []

Result: 32 / 32 = 1.00

Super majority is in favor, issue is approved