Recipe #258: Tagging with an External Resource

glenrobson commented 2 years ago

Links

Original Issue: https://github.com/IIIF/cookbook-recipes/issues/258
Pull Request: https://github.com/IIIF/cookbook-recipes/pull/276
Preview: https://preview.iiif.io/cookbook/0258-tagging-external-resource/recipe/0258-tagging-external-resource/

Background and Summary

Building on the previous annotation recipes and in particular the basic tagging recipe approved in #77. Recipe 258 extends the simple tagging recipe by linking an annotation to an external URI rather than just a simple text string. This can be useful in tagging entities contained in textual content, places on a map to a Gazetteer or as in the example given linking a photograph of a fountain to the Wikidata entry.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.

Changes to the recipe will only be made after the TRC voting process has concluded.

kirschbombe commented 2 years ago

Typo at the end of the second paragraph in the Implementation notes section: "it must be a real URI at the time of the creation of the Annoation"
Third paragraph of Implementation notes section, the penultimate sentence needs subject/verb agreement
In the example manifest, do we need to include the human readable tag since recipes are supposed show the simplest implementation of a property or use case?

thehabes commented 2 years ago

Include manifest.json lines 49 and 66 in the highlighting (the open and closing brackets for the Annotation)

markpbaggett commented 2 years ago

In the example section, annotation is misspelled: "While the Annodation body that points to the Wikidata entry for the fountain is valid all alone"...

triplingual commented 2 years ago

I promise I know how to spell Annnnotation.

julsraemy commented 2 years ago

It would be better to use the concept URI of Wikidata: http://www.wikidata.org/entity/Q18624915 instead of https://www.wikidata.org/wiki/Q18624915:

              "body": [
                {
                  "type": "SpecificResource",
                  "source": "http://www.wikidata.org/entity/Q18624915"
                },

zimeon commented 2 years ago

My 👍 is with wikidata URI (and spelling) fix

markpbaggett commented 2 years ago

Great point @julsraemy . I think making sure that URI is content negotiable for RDF is important.

triplingual commented 2 years ago

Habitual notice that I voted 👍🏻 for my own recipe.

glenrobson commented 2 years ago

Issue 85 (Recipe #258: Tagging with an External Resource)

+1: 22 [azaroth42 cubap dlpierce emulatingkat glenrobson hadro irv jtweed julsraemy kirschbombe ksclarke markpbaggett mikeapp mixterj mposton-folger nfreire regisrob rentonsa thehabes tpendragon triplingual zimeon] 0: 0 [] -1: 0 [] Not TRC: 1 [digitaldogsbody] Ineligible: 2 [cjnishioka gigamorph]

Result: 22 / 22 = 1.00

Super majority is in favor, issue is approved

triplingual commented 2 years ago

@kirschbombe

* In the example manifest, do we need to include the human readable tag since recipes are supposed show the simplest implementation of a property or use case?

It's been a minute, but if I recall correctly, we discussed this and decided to include it so a viewer would have something to show the visitor even if or especially if the Wikidata URI wasn't linked or displayed, and to show a good practice in that way.

IIIF / trc