IIIT-Delhi / byld-website

Static Website for IIIT-Delhi's Software Dev Club Byld
https://iiit-delhi.github.io/byld-website/
8 stars 29 forks source link

Event page TODOs #20

Open peey opened 6 years ago

peey commented 6 years ago

https://github.com/virresh/byldWebsite/pull/19 implements them as found on the original website.

Here are some minor improvements which we should undertake (maybe in a separate PR)

virresh commented 6 years ago

actually dateTime is already handled currently by jekyll, the only point that needs to be taken care of is that it has to be in one of the standard formats (The current one is ISO 8601 format)

For the coming --- events thing, we can probably take a look at the events list, and in case one of them has a date which is greater that the current one, we display it as upcoming (and write a js routine for it)

virresh commented 6 years ago

Also https://shopify.github.io/liquid/filters/date/ suggests that simply writing date in format like June 19, 2018 also works so we don't have anything to do in there really...

virresh commented 6 years ago

Can you explain

Make navigation be present on all pages

a little ?

virresh commented 6 years ago

The line responsible for first point: https://github.com/virresh/byldWebsite/blob/master/site/assets/css/hackathons.css#L83

peey commented 6 years ago

Can you explain

Make navigation be present on all pages a little ?

I must've been looking at the original site http://byld.iiitd.edu.in/hackathons, which doesn't have the complete navbar on all pages