Closed virresh closed 6 years ago
Sorry about the very very late review.
Just checked out the netlify preview. Man, this is magic!
Very nice functionality.
Have you ported the UI as-is from the original site? If yes then the UI issues kanika mentioned could be opened as separate issues
Yep, all of it is the original UI from the site Probably a nice good-first-issue
Is the list of added blogs for testing or do you intend for them to be in the final release too?
I'd like to remove my medium blog :D It has some useless posts from first year which I don't think are dev-related.
I also find addition of Julia Evans' blog posts to our blog a little confusing. This is probably a good time to discuss what should / shouldn't be on this blog.
I think external good blogs could be either
The heading for external blogs could say something like "blogs we follow", "blogs that are awesome".
It makes more sense to me to showcase Byld members' blogs on the site. Anything which is on members' blogs which is dev-related is fine.
Also when we have the blog contest, as an added feature (probably a separate issue), I think it'd be good to specially mark the blog entries as "for the techblog contest" in some way.
The list of blogs are only for testing, I will remove all except Byld's medium publication before final release
The addition of Julia Evan's blog was just to test out integration of custom jekyll feeds, with minimum modifications
I'm a little reluctant to mark blogs as techblog contest because we want to keep them around for a long run and let them lead the future members of Byld community
Also, adding "blogs we follow" might be a good idea, not gonna implement it in this PR though. Probably a future addition
This uses a custom spinoff of the default gem available for post generation from feed. Adds a link to the original post in the generated .md file.
Nice link explaining the feed model: https://github.com/feedreader/pluto/tree/master/pluto-models
Works with wordpress feeds, medium publication's feed, jekyll feeds generated using the default plugin for feed (all three have been tested)
The default plugin under consideration is: https://github.com/jekyll/jekyll-feed
Possible Future Work:
Handle the case when person enters their personal medium feed Medium doesn't provide standard feeds for personal users... So we got to handle it, which is a pain right now.... :/
Add more useful metadata from the database into generated post ?
Closes #34 and
33