search

IIIT-Delhi / byld-website

Static Website for IIIT-Delhi's Software Dev Club Byld
https://iiit-delhi.github.io/byld-website/
8 stars 29 forks source link

Bootstrap 3.3.7 breaks old UI style #8

Closed virresh closed 6 years ago

virresh commented 6 years ago

I think the major change is within the container class from 3.0.0 to 3.1.x

Just noted this because the main div looks a little odd from the original website (Notice some extra spaces on either sides of the container) (And maybe upgrade to bootstrap 4.0.0 in future, but I'd be more interested in just fixing this at the moment)

virresh commented 6 years ago

This happens because container was shifted to container-fluid in bootstrap 3.1.x and the new container has those extra margins

peey commented 6 years ago

Oh, I hadn't noticed this. Probably shouldn't have updated bootstrap.

peey commented 6 years ago

@virresh changing row-fluid to row as suggested here fixes this.

But the question is, should we fix this or should we go back to bootstrap v3.0.0 for ease of porting rest of the website?

virresh commented 6 years ago

Yup cool then Let's switch back to 3.0.0 and make an issue for future to upgrade to 4.0.0 later