IIIT-Delhi / byld-website

Static Website for IIIT-Delhi's Software Dev Club Byld
https://iiit-delhi.github.io/byld-website/
8 stars 29 forks source link

head.html: remove author names meta tag #92

Closed peey closed 4 years ago

peey commented 4 years ago

It's used in link previews and that's possibly interpreting it as a blog post author, giving it a very prominent spot right below the title.

peey commented 4 years ago

@virresh I looked at the failure log and it seems like something in Jekyll build process is broken. Does this mean that automatic deployment won't work either (is it trigged by the CI or by webhooks?)?

virresh commented 4 years ago

Does this mean that automatic deployment won't work either

Yep. Automatic deploys won't work till the CI is fixed, because the static site built from Jekyll builds was the content that was pushed onto server

virresh commented 4 years ago

I'd hoped someone looking for good first issue would stumble here and fix it: https://github.com/IIIT-Delhi/byld-website/issues/91

Since nobody claimed it so far, making a fix for it now

peey commented 4 years ago

Ah my bad, I didn't notice failing builds and the existing issue.

virresh commented 4 years ago

It's used in link previews and that's possibly interpreting it as a blog post author, giving it a very prominent spot right below the title.

I suppose this should fix it. Rebase once and confirm with the netlify preview once?

(PS: PRs from forks much appreciated, but we'll let this one slide :p)

peey commented 4 years ago

Oh wow this created a merge commit. I thought I'd be able to rebase it from the UI itself. Will open a new PR.

virresh commented 4 years ago

Yep, Github UI is bad, (and has been bad for a long time now. ref: https://github.com/IIIT-Delhi/byld-website/pull/78#issuecomment-431831813)