IINemo / lm-polygraph

MIT License
111 stars 21 forks source link

Improve model parametrization #173

Closed rvashurin closed 4 months ago

rvashurin commented 5 months ago

Several improvements here:

Completes following Notion tasks:

ArtemVazh commented 5 months ago

I suggest removing the max_length parameter everywhere since we override it with max_new_tokens. Also, I suggest removing min_length in greedy_tokens.py or changing it to min_new_tokens, since it also overrides with a value equal to the input length.

rvashurin commented 5 months ago

@ArtemVazh max_length removed, but I suggest we do min_length stuff separately to not overload this PR with concepts and code.