search

IIT-BHU-InstiApp / lite-hai-backend

https://lite-hai.copsiitbhu.co.in/
13 stars 20 forks source link

Firebase Cloud Messaging #52

Closed davidgarg20 closed 3 years ago

krashish8 commented 4 years ago

@davidgarg20 Please add fcm-django to pipenv by running pipenv install fcm-django

davidgarg20 commented 4 years ago

How is that Pipfile changed but Pipfile.lock didn't.

I didn,t noticed that there was a error while locking. Thats why this happened

nishantwrp commented 4 years ago

@krashish8 please review.

krashish8 commented 3 years ago

@davidgarg20 The code looks good, however, there are errors with the Lint Checks. Maybe this can fix the raise-missing-from and refer this to fix imported-auth-user.

The imported-auth-user has been recently added in pylint (https://github.com/PyCQA/pylint-django/issues/244 and https://github.com/PyCQA/pylint-django/issues/278), that might be the reason those lines didn't produce errors before, right? @nishantwrp

davidgarg20 commented 3 years ago

@krashish8 Thanks bhaiya for the links to remove error . Errors removed.