IITC-CE / IITC-Button

Firefox/Chrome extensions that enables IITC features
GNU General Public License v3.0
16 stars 6 forks source link

Some plugins have dependencies, and their scripts must be injected in order. #18

Closed ryantheleach closed 5 years ago

ryantheleach commented 5 years ago

Depending on the (random) order the scripts are being loaded / sorted in on the external scripts, makes several plugins seem to be enabled / disabled at random due to errors.

It would be useful to make load order deterministic and sortable.

In addition, for toggling enabled status of plugins, it would be cool if they could be sorted alphabetically (as opposed to load order) or grouped into folders much like the default plugins are.

johnd0e commented 5 years ago

Externals plugins grouping is discussed in another issue: https://github.com/IITC-CE/IITC-Button/issues/3#issuecomment-489555737

And could you tell what exact issue do you have with loading order? Could you name problem plugins and show console log?

ryantheleach commented 5 years ago

It's only a suspicion, but I've had several plugins that depend on draw tools being available bomb out randomly, There may be another cause, I'll report more when I know more.

johnd0e commented 5 years ago

Do not worry. Proper plugins use some techniques so keep things in order, such as iitcLoaded hook. And even more: in upcoming version we will introduce new priority property.