isSmartphone vs isTouchDevice vs L.Browser.mobile vs ...

[johnd0e]

Currently we use a bunch of different methods in order to detect similar things:

• Leaflet's L.Browser.mobile (used in portal-level-numbers.user.js and in several parts of the core). There is also L.Browser.touch (seen in leaflet.draw-src.js until 7941ed7e2b21fec28ec083e7bf8999c74e43e492)
• isTouchDevice (used in player-tracker.user.js only) https://github.com/IITC-CE/ingress-intel-total-conversion/blob/d77562b91a5b1e0bf170b4257eb33316a0b9daa3/code/utils_misc.js#L220-L223
• isSmartphone (used most) https://github.com/IITC-CE/ingress-intel-total-conversion/blob/d77562b91a5b1e0bf170b4257eb33316a0b9daa3/code/smartphone.js#L1-L16

We should define clearly when we need each of the mentioned functions.

[johnd0e]

As for 7941ed7e2b21fec28ec083e7bf8999c74e43e492, I think that better fix L.Browser.touch itself (#189).

[johnd0e]

Ok, let me summarize:

• L.Browser.touch means that client is touch-aware. But it does not necessary mean that it has touchscreen/touchpad (but it may be attached in runtime). In most cases we actually do not need to know that, more info.
• isTouchDevice should be deprecated in favor of L.Browser.touch (#463) Alternatively, we could use something like this:

  function isTouchDevice() {
  return 'maxTouchPoints' in navigator && navigator.maxTouchPoints > 0;
  }

• L.Browser.mobile is now used in these cases
  • In assumption that mobile device has less power/memory: https://github.com/IITC-CE/ingress-intel-total-conversion/blob/master/core/code/data_cache.js Well, that is questionable nowadays.
  • In assumption that mobile device should have different scale factor: (That is partly true, but better if we consider devicePixelRatio and/or [...])
  • https://github.com/IITC-CE/ingress-intel-total-conversion/blob/master/core/code/portal_marker.js
  • https://github.com/IITC-CE/ingress-intel-total-conversion/blob/master/plugins/portal-level-numbers.js.
• Also we can detect if iitc is inside of IITCm: typeof android !== 'undefined'.
• isSmartphone should be used to detect if we are in 'mobile' intel view, or userAgent contains android/iphone substrings. The point of this detection: choose between desktop and mobile iitc view (with left/right side panes, etc.) TODO: I've not checked yet if it is used consistently. We need this function because:
  • Even in IITCm there is option to force desktop view (but there are own issues, see #225).
  • We also have iOS version of app, also with side panes.
  • Anyway, all this is not consistent from the beginning by design, e.g. we may run into issues when we run IITC on android/iphone but not in app (e.g. in mobile Firefox), so...

[johnd0e]

isSmarphone usage is also far from great

• some cases better to solve in plain css
• most other cases can be avoided by redesigning smartphone code [to be continued]