search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
285 stars 110 forks source link

Unable to show pop up window #146

Closed mxxcon closed 5 years ago

mxxcon commented 5 years ago

I have a plugin which creates a portal markers and once click on them there's a popup window with various actions and functionality. It works perfectly fine in regular iitc, but not iitc-ce. When I check Chrome dev console I see the following error message:

VM194:3049 Uncaught TypeError: Cannot read property 'lat' of null
    at Object.project (<anonymous>:3049:43)
    at Object.latLngToPoint (<anonymous>:2888:40)
    at NewClass.project (<anonymous>:5374:27)
    at NewClass.latLngToLayerPoint (<anonymous>:5396:29)
    at NewClass._updatePosition (<anonymous>:10886:23)
    at NewClass.update (<anonymous>:10823:8)
    at NewClass.onAdd (<anonymous>:10758:8)
    at NewClass.onAdd (<anonymous>:11012:30)
    at NewClass._layerAdd (<anonymous>:7973:8)
    at NewClass.whenReady (<anonymous>:5840:13)

Running latest released version of iit-ce 0.29.1.20190315.122355

johnd0e commented 5 years ago

Thank you for report. Could you show plugin itself?

mxxcon commented 5 years ago

Unfortunately I can't. It's a restricted access plugin. :(

johnd0e commented 5 years ago

Ok, Most likely cause of the issue is changes in leaflet library: IITC-CE uses most recent version, which is not fully compatible with old 0.7.7 of stock iitc.

So probably your plugin need to be fixed to support modern leaflet, but we cannot be sure without seeing plugin sources.

Thus if you are really interested in using that plugin in IITC-CE than you have fix it yourself. Otherwise you may consider to show sources in private manner.

johnd0e commented 5 years ago

@mxxcon

Feel free to reopen the issue if you get sample code to reproduce the problem.