search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
279 stars 105 forks source link

DOMException: Failed to execute 'querySelectorAll' on 'Document': [...] is not a valid selector. #186

Open johnd0e opened 5 years ago

johnd0e commented 5 years ago

If enable [x] Pause on caught exception in debugger then there are many similar exceptions with such selectors:

Perhaps it is normal, as jQuery seems to work without problems (I cannot be completely sure, as our jQuery copy is minified, so it's not so easy to debug it in place).

But even if all is ok - it would be good to change our code to not emit such exceptions, to make debugging simpler.

AlfonsoML commented 5 years ago

The two exceptions in jquery-3.3.1.min.js are internal to that library and I would say that it's not possible to get ride of them as long as jQuery is being used. In Firefox it seems that it's possible to put it in a "black box", but there are far too many caught exceptions besides jQuery.

johnd0e commented 5 years ago

The two exceptions in jquery-3.3.1.min.js are internal to that library

Yes. And actually these are one-time exceptions, so I do not bother much. But exception with #chatcontrols a:contains('faction') is really annoying 'cause it repeats multiple times.

Although selector itself is valid for jQuery, I still prefer to revise that code, as it disturbs debugging IITC.