search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
285 stars 110 forks source link

Add Zaso plugins #219

Open modos189 opened 5 years ago

modos189 commented 5 years ago

Zazo`s is not developing plugins now, but he has given permission to add his plugins to our repository and change if necessary.

He has a lot of interesting plugins. I think we can add most of them to our repository.

johnd0e commented 5 years ago

There is no public repo for these plugins. May be he has private one?

It'd be good to keep old commits history. Also I know that not all his plugins are published.

modos189 commented 5 years ago

He has a git account, but is managing everything in a local repository on his PC. He thinks he will be back later this year, but currently has too much RL.

johnd0e commented 5 years ago

managing everything in a local repository on his PC.

Is it possible to put it online? If there is some unrelated stuff then we can filter it out.

modos189 commented 5 years ago

I'm afraid he can't do that right now.

johnd0e commented 5 years ago

OK, then we should remind about it later.

MysticJay commented 5 years ago

I have just started to find my way through GitHUB, nevertheless I will take care of this task. Give me a couple of days to get this beast under control.

johnd0e commented 5 years ago

@MysticJay I like your enthusiasm! What exactly are you going to do for this issue?

MysticJay commented 5 years ago

As agreed with @modos189 I'll start with importing "Multi-Project-Extension". That will not have any side effects. Can I get you on TG?

johnd0e commented 5 years ago

I'll start with importing "Multi-Project-Extension"

Are you going to add raw scripts from Zaso homepage? Or you have original git repo with full commits history?

Can I get you on TG?

You can use chat at https://www.reddit.com/r/IITC/

MysticJay commented 5 years ago

I talked with Zaso. He only operates his GIT locally. So yes, I will add the scripts one by one. Without history. In case it will be available one day we can still add that.

MysticJay commented 5 years ago

Most of Zaso's tools are explained in this TG-Channel: https://t.me/ZasoItems

johnd0e commented 5 years ago

Some thoughts:

  • [x] Multi project extension #221
  • [x] Bkmrks Fixes for MPE
  • [ ] DrawTools Plus

This (or similar) functionality should be integrated with IITC to be available directly, without separate plugins. I am no sure thought that in exact implementation. This needs to be investigated.

@modos189 So do you mean that we should add only these 3 plugins?

johnd0e commented 5 years ago

And I have some general concerns about Zaso (or any 3rd-party) plugins importing to main repo.

So simple question: why ever we add any plugin here? Answer seems obvious: plugin is useful. But: should we really add here every useful plugin we can found in the net? There are dozens or hundreds of wonderful plugins.

In general I suppose we should not add plugins that have own place in the internet.

  1. It is confusing: people see same plugins in different places and wondering what is the difference. There should be single place where plugin developed. If author actually transfer his abandoned plugin to us - he could state that explicitly, at former homepage. And there will be even worse if author continues developing on his homepage (so our version becomes outdated, or forks develop in different ways).

  2. Adding plugin to main repo we have to bring in some value. And what is the value if plugin was always available from it's own homepage (which is better than ours, has screenshots, etc)? We can add value by actually developing that plugin, enhancing, fixing bugs. If is is not in case - I do not see point of such additions. Yes, plugin is great. It's worth 'must-have' section of IITC site.

I love Zaso plugins. And I'd love to support them if he'll decide to transfer his repo to IITC-CE, and it will be officially. Or we can add plugins, that we actually enhancing.

So I strongly dislike the idea to duplicate plugins here 'just in case'. Why? Just add links to them.

MysticJay commented 5 years ago

Zaso has ever since seeked to integrate his work into the official IITC. Why it did not make its way I have no idea.

The three plugins I am working on right now have the least impact but the most value for all users. Switching between different DRAWS and sets of Bookmarks is most essential for anyone planning OPs, esp. when different OPs are planned at the same time.

You are right, there are hundreds of plugins (I just received a list with over 400). But many address a single missing function or a fancy idea. Some must not be named, are faction specific or even violate TOS. Still they have a "main idea" and that is what we should adopt.

The original Bookmarks and Drawtools are Zaso's developments. If his updates to these plugins do not deserve to merge no other new plugin should have.

I do not seek to add those as plugin extensions (like they exist today) but to integrate their new functions with the base plugins. Still I have to do that step by step in a matter that does not break anything existing, but is still reviewable for the maintainers. M.

MysticJay commented 5 years ago

As a next step I want to integrate draw-tools-plus with draw-tools. Adding MPE-Support and the new functions (like merge) will make the review difficult. So should I start with MPE-Support or should I start with the new functions?

johnd0e commented 5 years ago

Switching between different DRAWS and sets of Bookmarks is most essential for anyone planning OPs

This is true. And Zaso's plugins here are extremely useful. But why duplicate them in our repo? They have own homepage. We might link to it.

If he does not have plans to develop that plugins - then I agree, we can adopt them here. In this case it'll make sense to remove download links from old homepage (like is done with Bookmarks).

I do not seek to add those as plugin extensions (like they exist today) but to integrate their new functions with the base plugins

Oh, this is completely another case. This is best approach.

Still I have to do that step by step in a matter that does not break anything existing, but is still reviewable for the maintainers.

Sure. Than let's continue related discussion in #221.

johnd0e commented 5 years ago

As a next step I want to integrate draw-tools-plus with draw-tools.

Consider #2, there are many other draw-tools-related PRs waiting. It is a big work - to analyse all, and decide which merge order would be optimal.

So should I start with MPE-Support or should I start with the new functions?

Do not hurry to integrate MPE support, as it is also not sole existing implementation of multiple projects, and we need to chose the best. I suppose then better start with Plus-functions (also considering #2-alternatives).

MysticJay commented 5 years ago

Reviewing other PRs / Feature Requests will take time. Merging them will be even more complex. Thus I'd prefer the following:

MysticJay commented 5 years ago

@modos189 step2 done.