search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
285 stars 110 forks source link

IITC-Mobile: versionCode will be wrong for shallow clones #284

Closed johnd0e closed 3 years ago

johnd0e commented 4 years ago

Currently versionCode value is generated by this command: https://github.com/IITC-CE/ingress-intel-total-conversion/blob/f3f5ebd79112d56ad8b370fe08c800a1b1b5592a/mobile/app/build.gradle#L6

In case of our repo clone is shallow - we get wrong number.

Perhaps we should make sure here that repo is not shallow, may be put git fetch --unshallow to build.gradle. (But there is pitfall: https://stackoverflow.com/questions/28001878/git-fetch-unshallow-gives-fatal-unshallow-on-a-complete-repository-does-n#35124035)

modos189 commented 3 years ago

fixed in https://github.com/IITC-CE/ingress-intel-total-conversion/pull/305