Permanent portal entities

[johnd0e]

Currently portal entity (represented by CircleMarker) is not permanent: every time we get some data with newer timestamp - portal marker is recreated:

createPortalEntity()

https://github.com/IITC-CE/ingress-intel-total-conversion/blob/36a9b69e55c409a091523401422f532e628c3b1d/core/code/map_data_render.js#L292-L307

So all additional data (potentially attached by plugins) is discarded, including event listeners and other leaflet-binded things. In such case two hooks are run consequentially:

https://github.com/IITC-CE/ingress-intel-total-conversion/blob/36a9b69e55c409a091523401422f532e628c3b1d/core/code/map_data_render.js#L225 https://github.com/IITC-CE/ingress-intel-total-conversion/blob/36a9b69e55c409a091523401422f532e628c3b1d/core/code/map_data_render.js#L351

So data is discarded, but not completely lost: plugin may restore some data from previousData property. But as you see it's not so obvious and in many cases it may be tricky or cumbersome - to keep continuity between separated portal entities.

I propose to change this approach to some more simple and consistent: keep same portal marker, and only update it's data. Examples of potential benefits:

• Use leaflet event system for portals. See also #217. In particular, this may help to implement item 1 of https://github.com/IITC-CE/ingress-intel-total-conversion/issues/197#issue-443106932 (and all similar).
• Use other portal-binded objects, like tooltips (#195).
• Keeping permanent (but updating) entity data may help with issues like #324
• With some extent, it is important step towards https://github.com/IITC-CE/ingress-intel-total-conversion/issues/121#issuecomment-585100660 Another necessary change here - keep markers removed from map in some cache. Ether as leaflet objects, or just raw data (I'm not sure yet).

[johnd0e]

I propose to change this approach to some more simple and consistent: keep same portal marker, and only update it's data.

But we must consider compatibility, so all current hooks should stay.

1. Instead, we could extend hook data with additional property update (both hooks)
2. Alternatively, we may leave old hooks apart (keep as they are), and implement this as completely independent event system #217.

107 is another important improvement (though not directly related to subj).

[MysticJay]

Related problem? Hook portalSelected gets executed two or three times when a portal is selected. code to check:

window.addHook("portalSelected", someFunction);
function someFunction(d) {
  console.log(d);
}