search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
284 stars 110 forks source link

More cases to request write storage permissions #34

Closed johnd0e closed 5 years ago

johnd0e commented 5 years ago

Request write storage permissions only if you add scripts.

When I open *.user.js at Chrome webpage (or in file manager) it proposes list of applications. I select IITC and after confirmation all seems ok, but then Plugins settings screen appears without user plugins.

There should be permission request, I suppose.

And I think this even will not be enough, consider this case: IITC was once installed and we have user plugins in IITC-Mobile/plugins directory. Then we uninstall apk, and install it again. Will we get permission request?

Originally posted by @johnd0e in https://github.com/IITC-CE/ingress-intel-total-conversion/issues/4#issuecomment-446499237

modos189 commented 5 years ago

And I think this even will not be enough, consider this case: IITC was once installed and we have user plugins in IITC-Mobile/plugins directory. Then we uninstall apk, and install it again. Will we get permission request?

I thought read permissions were now set to default. Turns out not. Old external userscripts will not be shown until the permissions are granted (for example, by adding a new script).