search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
290 stars 109 forks source link

Error when clicking at portaildetails/imgpreview [mobile] #41

Closed johnd0e closed 5 years ago

johnd0e commented 5 years ago 
VM2568:433 Uncaught TypeError: Cannot read property 'naturalWidth' of undefined
    at HTMLDivElement.<anonymous> (<anonymous>:433:33)
    at HTMLDivElement.dispatch (<anonymous>:15833:41772)
    at HTMLDivElement.y.handle (<anonymous>:15833:39791)

https://github.com/IITC-CE/ingress-intel-total-conversion/blob/70b6077f1e56eb9449e6cf5b00a191f608c8798c/code/boot.js#L7-L11

As I understand this event handler in not meant to fire in mobile view mode, and here we see the (unsuccessful) attempt to turn it off:

https://github.com/IITC-CE/ingress-intel-total-conversion/blob/70b6077f1e56eb9449e6cf5b00a191f608c8798c/code/smartphone.js#L145

johnd0e commented 5 years ago

Blame https://github.com/IITC-CE/ingress-intel-total-conversion/commit/ea5349c14640513ae5a60d2930ea36c1b140fe12

I cannot see the point of that change. Perhaps it should be reverted.