IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
283 stars 109 forks source link

portal-list: filters / statistics api #457

Open johnd0e opened 3 years ago

johnd0e commented 3 years ago

Atm portal-list already has limited filter support, by team (All/Neutral/Resistance/Enlightened).

456 expands filters to support portal history statuses. But currently I feel it a bit inconsistent:

Another question: filters/statistic feature is implemented for history only, and I feel that as arbitrary choice, as user might want to have filter by any other field too.

So I propose to implement some plugin API to allow adding arbitrary filters. But we have to consider UX issues:

  1. How to handle (potentially) large amount of filters? Every filter takes valuable screen space even if unused.
    • Simplest solution: customize set of filters via some settings.
    • Smarter solution: call filtering by some existing (or just tiny enough) interface element. E.g. tap-hold column title.
      1. More intuitive "negative" filtering, e.g.:
        • Second tap on same filter may turn it negative (but it's make it harder to reach).
        • May be we need special (tiny enough) control element.
  2. Should filtering be column-based?
    • This cover most cases, but not all.
    • From the other side, that feels consistent. The filter may take own place in portalslist.fields table items.
    • But: standard "Neutral/Resistance/Enlightened" are column-based but still separate filters. Should that be just an exception, or we allow a column to provide more than single filter?
      1. [to be continued]
le-jeu commented 3 years ago

related #451

MysticJay commented 3 years ago

@johnd0e 1) The "negative" filte is NOT new it has been there for teams as well since ages. 2) Do not construct filtering-themes that noone requested. The fact that you did not eaven realize the negative filter was there before shows how little need there is.

IMHO we do not need that complexity. Neither for IITC nor for Ingress gameplay.

johnd0e commented 3 years ago

1) The "negative" filte is NOT new it has been there for teams as well since ages. [...] The fact that you did not eaven realize the negative filter was there before shows how little need there is.

I have to admit that you are right. But:

And all changes with #456, where negative filter is essential. That's why I propose to make it more intuitive.

2) Do not construct filtering-themes that noone requested. [...] IMHO we do not need that complexity

I've opened this issue for discussion (of several different question). Sure I am not going to construct anything complex without real need.

MysticJay commented 3 years ago

@johnd0e Reading the manual (helptext at the bottom) helps to know about features. So if you have a good idea for a more intuitive solution go ahead, but provide the features for those who are happy with what we have. I guess this was already discussed when portal-list was introduced ages ago.

johnd0e commented 3 years ago

but provide the features for those who are happy with what we have.

For those who are starved for features we are providing test-builds, and I will push #456 there too (soon).

nexushoratio commented 7 months ago

2) Do not construct filtering-themes that noone requested. The fact that you did not eaven realize the negative filter was there before shows how little need there is.

FTR, I am currently looking through existing issues because I want to do the following on the portal-list:

Filter portals where health < N% and sort by distance.

I've been using IITC for over a decade (tough took most of the last 4 years off), and I never knew about the negative faction filtering. Though now that I do, I will certainly make use of it!