search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
285 stars 110 forks source link

Plugins are not listed in About-IITC Dialog #513

Closed McBen closed 2 years ago

McBen commented 3 years ago

If the main script is loaded first it may execute it's boot-routine before other scripts have finished loading. This leads to an incomplete bootPlugins.info array (some items are still left in the bootPlugins array).

Tested on FF with TM, installed IITC-main first, then a ~12 other plugins. On first start only one plugin was listed in the about dialog. On a second run it lists 6. works fine if main script is loaded last

NOTE: since bootPlugins is an array bootPlugins.info should be moved to another variable

johnd0e commented 3 years ago

@McBen Have the the issue get more severe after #485? Could you check?

McBen commented 3 years ago

yes, reverting #485 helps a lot. The extra setTimeout of 073f7eb is looking good too.

Atleast I wasn't able to reproduce this issue on current system. But it's hard to tell if this is a real fix. Can't say if caching, system timing or weather condition is involved too. (even with the old code the plugin list were growing after multiple reloads)

johnd0e commented 3 years ago

But it's hard to tell if this is a real fix.

Sure it is not ultimate fix. I suppose we should re-inspect bootPlugins every time before About-window is opened.

McBen commented 3 years ago

I suppose we should re-inspect bootPlugins every time before About-window is opened.

hidden in PR #514 https://github.com/IITC-CE/ingress-intel-total-conversion/pull/514/commits/635a77bfc8dba8379343a0e026ac76a77706c913 :)