search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
285 stars 110 forks source link

exception in window.setupPlayerStat causing no passcode reward dialog #589

Closed jim0watters closed 1 year ago

jim0watters commented 1 year ago

There is a bug in IITC subroutine window.setupPlayerStat that throws an error that is noticed when trying to redeem passcodes. The passcode is redeemed but no message of the reward is displayed. I am avoiding this bug by commenting out the lines 24847 to 24850

 // if(data.playerData) {
 //   window.PLAYER = data.playerData;
 //   window.setupPlayerStat();
 // }.

I have not figured out what is wrong inside of setupPlayerStat.

I added the work around a few months ago and forgot about it until another Agent was complaining about the same issue of no dialog of passcode rewards. I have reenabled the code and will try to remember to add a breakpoint before putting in my next passcode.

le-jeu commented 1 year ago

isn't this fixed by #559 in 0.33.0 ?

jim0watters commented 1 year ago

Don't have any passcodes to test and been a while since I saw the exact exception, but that looks like the same issue. Thank you.

xscreach commented 1 year ago

I've been redeeming some codes on versions 0.33.0-0.35.0 and all displayed the passcode content.

Imho this issue can be closed

jim0watters commented 1 year ago

Issue has been fixed. Redeeming codes since 0.33.0 has not been a problem.