IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
284 stars 110 forks source link

Bookmarks not showing #645

Open BountyHunter23 opened 1 year ago

BountyHunter23 commented 1 year ago

IITC 0.35.1 [release] Bookmarks plugin 0.4.2 No bookmarks option available in the IITC menu and can not create new bookmarks. Other plugins in use: Draw Tooks, Wasabee, Bannergress, Machina and others.

xscreach commented 1 year ago

Tested on IITC 0.35.1 both PC and Mobile + Bookmarks plugin 0.4.2

Bookmark portal (star) available and working creating/removing new portla bookmark. Bookmark window/pane available - ability to create/remove bookmars for maps. Bookmark highlighter and Bookmarked Portals layer also working showing bookmarked portals on map (each it's own way).

Suggestion - remove any plugin that might interfere with these. Note that bookmarks plugin hasn't been changed since Jul 26, 2022.

If that does not help try to provide more information like:

image image image image

MysticJay commented 1 year ago

Please show your "About IITC" from the toolbox. If you have Faction-only plugins that should not be shown, either disable them first from Tampermonkey or send the screenshot to a DEV of your faction in Telegramm.

MysticJay commented 8 months ago

@BountyHunter23 does the issue persist?

BountyHunter23 commented 8 months ago

Yes,and I have given up trying to resolve it. Bookmarks work fine on both our phones and tablets, but not on my laptop.

On Sat, Jan 20, 2024 at 5:34 PM MysticJay @.***> wrote:

@BountyHunter23 https://github.com/BountyHunter23 does the issue persist?

— Reply to this email directly, view it on GitHub https://github.com/IITC-CE/ingress-intel-total-conversion/issues/645#issuecomment-1902294391, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBELKYMWT2JEOMTVVGPN26LYPRA77AVCNFSM6AAAAAA2CZ5VPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGI4TIMZZGE . You are receiving this because you were mentioned.Message ID: @.***>

-- Cecil and Linda Cell: 831-809-6459

xscreach commented 8 months ago

@BountyHunter23 imho it would be best if you came to visit us on telegram - https://t.me/+1xncfR_TV3BjZTIy

We could try to solve the issue "live" 😉

Because we'll need some more information from you... Like screenshots of:

And some description of what you are missing and where. Something like:

All of that and maybe more will be needed before we can even start trying to figure out what's going on 🤷

BountyHunter23 commented 8 months ago

Ok, I will do that.

On Sun, Jan 21, 2024 at 10:03 PM xscreach @.***> wrote:

@BountyHunter23 https://github.com/BountyHunter23 imho it would be best if you came to visit us on telegram - https://t.me/+1xncfR_TV3BjZTIy

We could try to solve the issue "live" 😉

Because we'll need some more information from you... Like screenshots of:

  • "about IITC" dialog - if you have some plugins you don't want people to know about, disable them first
  • developer console output - press F12 and check tab "console" for red lines

And some description of what you are missing and where. Something like:

  • there should be a star ⭐ in info panel but I don't see that
  • nothing happens when I click the star in info panel
  • I can click the star, it changes colour, but I don't see change in bookmark list
  • etc...

All of that and maybe more will be needed before we can even start trying to figure out what's going on 🤷

— Reply to this email directly, view it on GitHub https://github.com/IITC-CE/ingress-intel-total-conversion/issues/645#issuecomment-1903034004, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBELKYONQJK47AQJAYSFBD3YPXJJBAVCNFSM6AAAAAA2CZ5VPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBTGAZTIMBQGQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Cecil and Linda Cell: 831-809-6459

Ashayazu commented 2 months ago

Hello, I seems to have a similair issue with the bookmarks plugin. it seems to work on my phone and tablet but I cannot make bookmarks in chrome/firefox on PC with neither IITC Button or tampermonkey.

These are the errors from the console when I press the star button and Write Bookmarks button from FanFields2:

324f024f850242880d2168a1f587b2fd

VM461:396
    Uncaught 
        TypeError: Cannot read properties of undefined (reading 'idOthers')
            at window.plugin.bookmarks.addPortalBookmarkByMarker (<anonymous>:396:47)
            at window.plugin.bookmarks.addPortalBookmarkByGuid (<anonymous>:428:29)
            at window.plugin.bookmarks.switchStarPortal (<anonymous>:375:29)
            at HTMLAnchorElement.onclick (intel:1:25)

        window.plugin.bookmarks.addPortalBookmarkByMarker @ VM461:396 
        window.plugin.bookmarks.addPortalBookmarkByGuid @ VM461:428 
        window.plugin.bookmarks.SwitchStarPortal @ VM461:375 
        onclick @ intel:1 

(VM461:396) window.plugin.bookmarks.bkmrksObj['portals'][window.plugin.bookmarks.KEY_OTHER_BKMRK]['bkmrk'][ID] = {
(VM461:428) window.plugin.bookmarks.addPortalBookmarkByMarker(marker, doPostProcess);
(VM461:375) window.plugin.bookmarks.addPortalBookmarkByGuid(guid, true);
(intel:1) window.plugin.bookmarks.switchStarPortal();return false;

The Write Bookmarks button from FanFields2 does not work either and reports the following error

VM462:389 
    Uncaught 
        TypeError: Cannot set properties of undefined (setting 'id1721648581386452')
            at thisplugin.saveBookmarks (<anonymous>:389:62)
            at HTMLAnchorElement.onclick (intel:1:25)

        thisplugin.saveBookmarks @ VM642:389
        onclick @ intel:1

(VM642:389) window.plugin.bookmarks.bkmrksObj.portals[folder_ID] = {"label":label,"state":1,"bkmrk":{}};
(intel:1)          <!DOCTYPE html>
Ashayazu commented 2 months ago

Small update, the problem migrated to my phone and tablet as well. I do not know how yet. I did not update any of the plugins on those devices. so it breaks over time looks like?

DanielOndiordna commented 2 months ago

I think your stored (localstorage) bookmark data is corrupt. Did you ever import bookmarks data? The bookmarks plugin does not check for valid formatted import or stored data. The only way to fix this, is to use the bookmarks menu to delete all bookmarks, or to manually delete the localstorage key for bookmarks.

Ashayazu commented 2 months ago

I've never imported bookmarks. only used the sync plugin to match the data on my phone and tablet. Deleting all bookmarks from the Bookmark Opt did not do anything. Now that I mention it when I reset the bookmarks and go to copy bookmarks after I get this in there:

[{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.102814,"lng":6.874248},{"lat":53.103173,"lng":6.872232}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.102814,"lng":6.874248},{"lat":53.103173,"lng":6.872232}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.103173,"lng":6.872232},{"lat":53.104405,"lng":6.86551},{"lat":53.103741,"lng":6.866543}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.103741,"lng":6.866543},{"lat":53.104228,"lng":6.865426}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.104405,"lng":6.86551},{"lat":53.103741,"lng":6.866543}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.103173,"lng":6.872232},{"lat":53.104405,"lng":6.86551}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.103173,"lng":6.872232},{"lat":53.103741,"lng":6.866543},{"lat":53.100874,"lng":6.86798}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.103741,"lng":6.866543},{"lat":53.104228,"lng":6.865426},{"lat":53.100874,"lng":6.86798}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.104228,"lng":6.865426},{"lat":53.100874,"lng":6.86798}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.101698,"lng":6.86669},{"lat":53.099702,"lng":6.867695}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.100874,"lng":6.86798},{"lat":53.101698,"lng":6.86669}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.100874,"lng":6.86798},{"lat":53.101698,"lng":6.86669},{"lat":53.099702,"lng":6.867695}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.104546,"lng":6.865062},{"lat":53.099702,"lng":6.867695},{"lat":53.09886,"lng":6.867904}],"color":"#a24ac3"},{"type":"polygon","latLngs":[{"lat":53.1047433806663,"lng":6.865189075469971},{"lat":53.10357108451815,"lng":6.861326694488525},{"lat":53.09919079422769,"lng":6.862828731536865},{"lat":53.09683620389092,"lng":6.870408654212952},{"lat":53.09660750220414,"lng":6.870601773262024},{"lat":53.09662360799652,"lng":6.870789527893066},{"lat":53.09912637486609,"lng":6.872012615203857},{"lat":53.10281100730497,"lng":6.8753814697265625}],"color":"#a24ac3"}]

Should it not be empty? thus maybe indicating local storage is broken? How do I go about manually deleting the localstorage key?

Edit: even removing tampermonkey and all the plugins related. does not fix the issue. Is there a local cache/file I need to remove in order for it to completely reset?

DanielOndiordna commented 2 months ago

That is Draw tools data. And due to sync it copied over from your pc to mobile. Not automatically "over time", it is something you must have done yourself accidentally at some point. You can clear the bookmarks data on both pc and mobile by deleting the stored bookmarks data key.

Ashayazu commented 2 months ago

ok so far it looked like the synced bookmark database was corrupt. I managed to delete the bookmarks from my phone and let it sync up with the rest of my devices. I'm still not sure why I am not able reset it from my pc though.

one last question. On the pc version I have 2 extra buttons on the bookmarks menu. Save box position and Reset box position.

d78ecda47c6ee5141199d2acf99d27be

Not sure what these do but I do not have the same options on mobile. All my platforms run the same plugins and versions: 0.4.4 [release] 2024-03-20-144515

DanielOndiordna commented 2 months ago

The "box" on the pc is the floating bookmarks list. You can drag it around. On mobile, the list view is placed in a full screen area, from the side pane. You can not position this view.

Ashayazu commented 2 months ago

Unless you use desktop view on the mobile devices ;p. Anyway thanks for the input, it solved my issue albeit with a workaround.